Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIEXPMGR-113 Support claims export #212

Merged
merged 5 commits into from
Jan 9, 2025
Merged

UIEXPMGR-113 Support claims export #212

merged 5 commits into from
Jan 9, 2025

Conversation

usavkov-epam
Copy link
Contributor

@usavkov-epam usavkov-epam commented Jan 3, 2025

Purpose

The primary goal of this pull request is to enhance the ui-export-manager by introducing support for exporting claims. This functionality is essential for users who need to manage and export claim data efficiently within the FOLIO platform.

https://folio-org.atlassian.net/browse/UIEXPMGR-113
https://folio-org.atlassian.net/browse/UIEXPMGR-114

Approach

  • Implementation of Claims Export Functionality:

    • Introduced new logic to handle the export of claims, ensuring that the feature integrates seamlessly with existing export functionalities.
  • Optimization of CQL Query Construction:

    • Updated the logic for building CQL queries to improve performance and maintainability. This includes:
      • Grouping and deduplicating CQL conditions by their keys and values.
      • Ensuring reliable alphabetical sorting of keys using String.localeCompare for consistent query generation.
      • Minimizing the size and complexity of generated queries while preserving their correctness.

Screenshot

chrome_TZpoTyLpsE.mp4

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@usavkov-epam usavkov-epam self-assigned this Jan 3, 2025
Copy link

github-actions bot commented Jan 3, 2025

Jest Unit Test Statistics

80 tests  +1   80 ✔️ +1   2m 20s ⏱️ +8s
21 suites ±0     0 💤 ±0 
  1 files   ±0     0 ±0 

Results for commit d2a8306. ± Comparison against base commit f1b4d92.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 3, 2025

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit d2a8306. ± Comparison against base commit f1b4d92.

♻️ This comment has been updated with latest results.

@usavkov-epam usavkov-epam marked this pull request as ready for review January 8, 2025 09:04
@usavkov-epam usavkov-epam requested review from vashjs, UladzislauKutarkin and a team January 8, 2025 09:23
@Dmytro-Melnyshyn Dmytro-Melnyshyn requested a review from a team January 9, 2025 08:30
@usavkov-epam usavkov-epam merged commit 9262192 into master Jan 9, 2025
6 checks passed
@usavkov-epam usavkov-epam deleted the UIEXPMGR-113 branch January 9, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants